Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[choreo] Event marker refactor #773

Merged
merged 33 commits into from
Oct 8, 2024
Merged

[choreo] Event marker refactor #773

merged 33 commits into from
Oct 8, 2024

Conversation

shueja
Copy link
Collaborator

@shueja shueja commented Sep 25, 2024

No description provided.

@calcmogul calcmogul changed the title Event marker refactor [choreo] Event marker refactor Sep 29, 2024
@shueja shueja marked this pull request as ready for review October 5, 2024 22:25
spacey-sooty
spacey-sooty reviewed Oct 6, 2024
View reviewed changes
.vscode/settings.json Outdated Show resolved Hide resolved
@spacey-sooty spacey-sooty linked an issue Oct 6, 2024 that may be closed by this pull request
Re-enable PPLib event markers and add ChoreoLib markers to GUI #770
Closed
@shueja
Copy link
Collaborator Author

shueja commented Oct 8, 2024

C++, Java and Python deserialization changes have been tested. Ready for review.

calcmogul
calcmogul approved these changes Oct 8, 2024
View reviewed changes
Copy link
Member

@calcmogul calcmogul left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the event marker stuff have C++ tests? I guess Python just prints them, which isn't much of a test.

@shueja shueja enabled auto-merge (squash) October 8, 2024 18:21
calcmogul
calcmogul requested changes Oct 8, 2024
View reviewed changes
Copy link
Member

@calcmogul calcmogul left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should add an assert to the Java test while you're at it. The commented out imports in ChoreoTests.java can also be removed.

@shueja shueja merged commit 916b1d3 into SleipnirGroup:main Oct 8, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spacey-sooty spacey-sooty spacey-sooty left review comments

@calcmogul calcmogul calcmogul approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Re-enable PPLib event markers and add ChoreoLib markers to GUI
3 participants
@shueja @calcmogul @spacey-sooty