Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C++ does not have two different spec versions for .chor and .traj #973

Closed
shueja opened this issue Dec 6, 2024 · 0 comments · Fixed by #978
Closed

C++ does not have two different spec versions for .chor and .traj #973

shueja opened this issue Dec 6, 2024 · 0 comments · Fixed by #978
Labels
component: choreolib-cpp
Milestone
2025-beta-7

Comments

@shueja
Copy link
Collaborator

shueja commented Dec 6, 2024 •
edited
Loading

In this PR, also update the schema-upgrade.md section that says C++ does not have version checking, and reference Choreo.h.
@shueja shueja added this to the 2025-beta-7 milestone Dec 6, 2024
spacey-sooty added a commit to spacey-sooty/Choreo that referenced this issue Dec 6, 2024
@spacey-sooty
[choreolib] Fix C++ version checking
e7c4cc0 
Resolves SleipnirGroup#973

Signed-off-by: Jade Turner <[email protected]>
@spacey-sooty spacey-sooty mentioned this issue Dec 6, 2024
Merged
spacey-sooty added a commit to spacey-sooty/Choreo that referenced this issue Dec 6, 2024
@spacey-sooty
[choreolib] Fix C++ version checking
46815da 
Resolves SleipnirGroup#973

Signed-off-by: Jade Turner <[email protected]>
spacey-sooty added a commit to spacey-sooty/Choreo that referenced this issue Dec 6, 2024
@spacey-sooty
[choreolib] Fix C++ version checking
2a6c27a 
Resolves SleipnirGroup#973

Signed-off-by: Jade Turner <[email protected]>
spacey-sooty added a commit to spacey-sooty/Choreo that referenced this issue Dec 6, 2024
@spacey-sooty
[choreolib] Fix C++ version checking
806c26f 
Resolves SleipnirGroup#973

Signed-off-by: Jade Turner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: choreolib-cpp
Projects
None yet
Milestone
2025-beta-7
Development

Successfully merging a pull request may close this issue.

[choreolib] Fix C++ version checking spacey-sooty/Choreo
1 participant
@shueja