Skip to content

Commit

Permalink
[BPK-964] Upgrade eslint versions
Browse files Browse the repository at this point in the history
  • Loading branch information
shaundon committed Oct 25, 2017
1 parent 5511301 commit e044fd6
Show file tree
Hide file tree
Showing 4 changed files with 1,700 additions and 12 deletions.
12 changes: 11 additions & 1 deletion changelog.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,19 @@

All notable changes to this project will be documented in this file.

The format is based on [Keep a Changelog](http://keepachangelog.com/)
The format is based on [Keep a Changelog](http://keepachangelog.com/)
and this project adheres to [Semantic Versioning](http://semver.org/).

## 3.0.0 - Upgraded `esling-config-airbnb peer dependencies`
### Changed
- Upgraded the following peer dependencies:
- babel-eslint: `^7.2.3` -> `^8.0.1`
- eslint: `^3.17.1` -> `^4.9.0`
- eslint-config-airbnb: `^14.1.0` -> `^16.1.0`
- eslint-plugin-import: `^2.2.0` -> `^2.8.0`
- eslint-plugin-jsx-a11y: `^4.0.0` -> `^6.0.2`
- eslint-plugin-react: `^6.10.0` -> `^7.4.0`

## 2.0.0 - Changed parser to `babel-eslint`
## Changed
- Changed parser to `babel-eslint` to support dynamic `import()` statements used with Webpack 2
Expand Down
26 changes: 25 additions & 1 deletion index.js
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,30 @@ module.exports = {
parser: 'babel-eslint',
extends: 'airbnb',
rules: {
'valid-jsdoc': ['error']
'valid-jsdoc': ['error'],

// We've decided we don't want this for now as it makes writing JSX more painful.
// See https://github.com/airbnb/javascript/issues/1584#issuecomment-335667272
"function-paren-newline": 0,

// False positive on custom propTypes + isRequired. https://github.com/yannickcr/eslint-plugin-react/issues/1389
"react/no-typos": 0,

// See https://github.com/evcohen/eslint-plugin-jsx-a11y/issues/339
"jsx-a11y/anchor-is-valid": ["error", {
"components": ["Link"],
"specialLink": ["to"],
"aspects": ["noHref", "invalidHref", "preferButton"],
}],

// See https://github.com/evcohen/eslint-plugin-jsx-a11y/issues/282
// We should probably change our code to adhere to the standard here.
"jsx-a11y/label-has-for": [ 2, {
"components": [ "Label" ],
"required": {
"some": [ "nesting", "id" ]
},
"allowChildren": false
}]
}
};
Loading

0 comments on commit e044fd6

Please sign in to comment.