[BPK-1043] Remove selected button state #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And also examples of buttons with both text and icon.
Generated by 🚫 dangerJS |
shaundon
force-pushed
the
bpk-1043-remove-selected-state
branch
from
5ee0de9 to
33c8838
Compare
shaundon
commented
Oct 11, 2017
| @@ -44,11 +44,9 @@ export default class App extends Component { | |||
| <View style={styles.container}> | |||
| <BpkButton type="primary" title={translationHelper.translate('BOOK_FLIGHT')} onPress={() => {}} /> | |||
| <BpkButton type="featured" title={translationHelper.translate('BOOK_FLIGHT')} onPress={() => {}} /> | |||
| <BpkButton selected type="secondary" title={translationHelper.translate('BOOK_FLIGHT')} onPress={() => {}} /> | |||
There was a problem hiding this comment.
Removing the selected one.
shaundon
commented
Oct 11, 2017
| <BpkButton disabled type="destructive" title={translationHelper.translate('BOOK_FLIGHT')} onPress={() => {}} /> | ||
| <BpkButton large type="primary" title={translationHelper.translate('BOOK_FLIGHT')} onPress={() => {}} /> | ||
|
|
||
| <BpkButton type="primary" title={translationHelper.translate('BOOK_FLIGHT')} icon={ArrowImage} onPress={() => {}} /> |
There was a problem hiding this comment.
Removing example of a button with both text and icon.
shaundon
commented
Oct 11, 2017
| </View> | ||
| </BVLinearGradient> | ||
| `; | ||
|
|
There was a problem hiding this comment.
I haven't removed tests for buttons that have both text and an icon, because as discussed we're not removing it, just not advertising the functionality.
matteo-hertel
approved these changes
Oct 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And also examples of buttons with both text and icon (not the code, just the references to it in docs, as discussed).