-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Slide controller & adjustable RelativeBubbleSlideChild #11
Open
ming-o-0
wants to merge
13
commits into
Skyost:master
Choose a base branch
from
ming-o-0:features/slide-controller
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wouldn't it be better to have the state inside slideActionConroller and instead of using stream parameters only calling slideActionController.goToIndex() or slideActionController.next()? One good example of this behavior is the PageViewController. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features
There are 2 arguments added to Showcase widget.
slideNumberStream
Trigger this to go to targeted slide. It is invoked by Stream. If receiving input is over length of slides or less, the showcase is finished. While providing position number less than -1, the showcase will stand still.slideActionStream
Trigger this to control slide to go next, back to previous or close. You can use StreamController to control slide like this example:There is a argument added to Showcase widget
enabledClickOnOverlayToNextSlide
Whether to enable click on overlay to go to next slide. (default totrue
)extraWidthRight
Additional width to the right. Working only with direction up & down.extraWidthLeft
Additional width to the left. Working only with direction up & down.extraHeightTop
Additional height to the top. Working only with direction left & right.extraHeightBottom
Additional height to the bottom. Working only with direction left & right.Notes
On both slideNumberStream and slideActionStream, I'm trying to cancel subscription when widget is disposed but after assign stream.listen() to a variable, the subscription does not work.