Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hooks for Cloud Functions #158

Closed
chpapa opened this issue Oct 24, 2017 · 6 comments
Closed

Hooks for Cloud Functions #158

chpapa opened this issue Oct 24, 2017 · 6 comments
Assignees
@howawong
Labels
type/improvement

Comments

@chpapa
Copy link
Contributor

chpapa commented Oct 24, 2017

Would be useful for Push Notification support. So the following are model around push notification.

  • Messages
    • after_message_sent
    • after_message_updated
    • after_message_deleted
  • Typing
    • typing_started
  • Conversation
    • after_conversation_created (direct / normal)
    • after_conversation_deleted
    • after_conversation_updated
    • after_user_entered_conversation (user / admin)
    • after_user_leave_conversation
@chpapa chpapa mentioned this issue Oct 24, 2017
Closed
9 tasks
@howawong
Copy link
Contributor

howawong commented Nov 1, 2017

Hey, what about user created and deleted?

@chpapa
Copy link
Contributor Author

chpapa commented Nov 1, 2017 •
edited
Loading

Hey, what about user created and deleted?

@howawong I think these are good Cloud Functions hook. Actually, there is one feature issue about it: SkygearIO/features#101

But I just didn't know normal apps will send a push notification when user sign up or deleted.

If you think when you work on this issue, it is easy for you to just add other cloud functions hook, feel free to do so.

Or did you meant something else?

@carmenlau
Copy link
Contributor

Missing parameter for the hook, need updating the spec

@howawong howawong mentioned this issue Nov 8, 2017
Merged
rickmak added a commit to SkygearIO/features that referenced this issue Nov 14, 2017
@rickmak
Add Chat Push Notification Spec
c1dedec 
refs #123, SkygearIO/chat#158
@howawong howawong mentioned this issue Nov 16, 2017
Merged
rickmak added a commit that referenced this issue Nov 17, 2017
@rickmak
Hooks for Cloud Functions
cc755fe 
* Messages
  * after_message_sent
  * after_message_updated
  * after_message_deleted
* Typing
  * typing_started
* Conversation
  * after_conversation_created (direct / normal)
  * after_conversation_deleted
  * after_conversation_updated
  * after_user_entered_conversation (user / admin)
  * after_user_leave_conversation

refs #158
@arsewizz
Copy link

glad that this issue's solved, eager to work on this

@rickmak
Copy link
Member

rickmak commented Nov 29, 2017

Current implementation is not capable to have multiple hooks of the same type.

@rickmak rickmak reopened this Nov 29, 2017
@rickmak
Copy link
Member

rickmak commented Nov 29, 2017

To be follow up at #182

@rickmak rickmak closed this as completed Nov 29, 2017
This was referenced Nov 30, 2017
Closed
Merged
rickmak pushed a commit that referenced this issue Nov 30, 2017
@howawong @rickmak
Add url in attachment field in message serialization for message hook
4dfab60 
Refs #158
rickmak added a commit to SkygearIO/chat-SDK-JS that referenced this issue Dec 4, 2017
@rickmak
Chat Hook Implementation
e6f1129 
refs SkygearIO/chat#158
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@howawong howawong

Labels
type/improvement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@rickmak @chpapa @carmenlau @howawong @arsewizz