Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI changes #4

Merged
merged 15 commits into from
Jun 1, 2023
Merged

UI changes #4

merged 15 commits into from
Jun 1, 2023

Conversation

WereTech
Copy link

The main change is to replace the old tool bar with a tool bar strip, adding a lot more functionality and easier to change.
Other changes include fixing the label texts, allowing the right-click context menu for a vtf to be outside of the image bounds, adding a close button to close the current loaded file, adding some window size minimums because they didn't have one in the first place, removing the alpha flags from the checkbox list as they cannot be changed anyways and instead they have a label indicating the vtf's alpha (I'm thinking of doing the same for the environment map flag as well because it's the same conditions as the alpha, but unsure where to put this), and changing the "frame, face, slice, mipmap" numbered box to only be adjustable when the vtf has more than one of any of these (they could not be adjusted regardless if the vtf didn't already have more than one, this would just make it a bit easier to know if the vtf does have more than any of these).

I have also decided to just include the third party dlls into the project so that they can be copied into the Build folder and remove the "Build Failed" error that was caused by the post build copy command. (I wanted this anyways to also be able to use the local debugger, as vtfedit relies on the other dlls to function)

Also please note that this will cause merging conflicts with the linux pull that I saw. Unsure what needs to be done to make them completely compatible but I hope I could get this pull added in.

Here's an image of how the main window looks now, if you want to make your decision to merge based on that.
https://i.imgur.com/wnnSQF2.png

WereTech added 13 commits May 11, 2023 05:34
Removed the Unused and Alpha flags from the checkbox list. Adjusted the labels to not get text wrapped, and tidied some other elements. Made the Frame, Face, Slice, and Mipmap number boxes in the Image tab set to ReadOnly if the value does not go over 1 (in this case, 0 = 1 as the starting point), this is to make it easier to see if the VTF has any more than one of any of these values at a glance instead of needing to attempt to change the values (they cannot be changed if it does not go over one as well, so this does not remove functionality)
… has tons more functionality than the bar

Other changes that were not mentioned in the previous push.

The alpha of the image is instead replaced by a label in the image tab with the text of what alpha the image is using, such as "Eight Bit Alpha".
…, and added a confirm dialog when using the Close button
…nd so I decided to put the external dlls into the project and change the paths

Note that this is strictly for 64 bit systems and will likely need a 32 bit dll for building 32 bit.
…g a download from other sites if the original vtfedit reloaded wasn't already downloaded
…, and added a pragma to disable an ignorable warning
…ne with all the changes for now and have tested everything I can think of
@Sky-rym
Copy link
Owner

Sky-rym commented May 16, 2023

very nais
if you're able to can you change the Red, Green, and Blue circles on the toolbars to be the letters R, G, and B with their respective colors
text can be bolded or unbolded whichever looks better and/or is possible
that way it's more identifiable by shape and for colorblind accessibility

also the linux pull was just a test for now, i'll have to mess with it more before it comes to the main branch

@WereTech
Copy link
Author

WereTech commented May 16, 2023

Here's the new images for the channels, not too sure about them because of the black outline, but it seemed necessary or they could be hard to look at when just the raw color. If you have better ideas for any of the icons, I'm open to changing them to whatever.

https://i.imgur.com/ycEOGmS.png (changed the tiling icon after the initial image)

@Sky-rym
Copy link
Owner

Sky-rym commented Jun 1, 2023

hey sorry about the wait, looks good, would you be able to compile the build with the new icons for me so i can add it to the gamebanana page?

@Sky-rym Sky-rym merged commit 0608c5d into Sky-rym:master Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants