Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aliases for 1.20 #88

Merged
merged 11 commits into from
Oct 1, 2023
Merged

Aliases for 1.20 #88

merged 11 commits into from
Oct 1, 2023

Conversation

TheLimeGlass
Copy link
Contributor

@TheLimeGlass TheLimeGlass commented Jun 8, 2023

Aliases for 1.20, optimized for the easiest understanding and most flexibility.

Each item individually tested and ensured for picking understand-ability like how any wall sign should equal any normal wall sign and any wall hanging sign.

Notes

  • that mangrove cannot be a tree type because it's saplings are named different and bamboo cannot be a tree type because it has no logs.
  • bamboo has MOZAIC as a different block in the set.
  • Moved stair variation properties to the globalvariation file for proper usage.

@TheLimeGlass TheLimeGlass marked this pull request as draft June 8, 2023 08:45
Copy link
Member

@sovdeeth sovdeeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good, just one concern.

decoration.sk Outdated Show resolved Hide resolved
Copy link
Member

@AyhamAl-Ali AyhamAl-Ali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done, hopefully we didn't miss anything

+global-variations.sk Outdated Show resolved Hide resolved
building.sk Outdated Show resolved Hide resolved
@Fusezion
Copy link

Before merging me might wanna wait till 1.20.2, as barriers were given a waterlogged state, which this hopefully won't be too long till then

@APickledWalrus APickledWalrus self-requested a review September 13, 2023 20:50
TheLimeGlass and others added 2 commits September 19, 2023 17:35
Co-authored-by: Ayham Al Ali <[email protected]>
Co-authored-by: Ayham Al Ali <[email protected]>
decoration.sk Outdated Show resolved Hide resolved
decoration.sk Outdated Show resolved Hide resolved
@Moderocky Moderocky merged commit 1ee77d8 into master Oct 1, 2023
@Moderocky Moderocky deleted the feature/1.20 branch October 1, 2023 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants