Runtime error highlighting #7402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Efnilite
approved these changes
Jan 6, 2025
|
You should do this on REP instead of SREP |
- Highlighting defaults to null now, if error(String) is used
…cess it - Cheers Sovde
cheeezburga
added
the
enhancement
sovdeeth
approved these changes
Jan 7, 2025
Open
Moderocky
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Overloads
RuntimeErrorProducer#errorandRuntimeErrorProducer#warningto allow for the text to be highlighted in the parsed syntax to be provided alongside the error text. This, ideally, will help with syntax elements which could throw more than 1 error in their execution, where different highlighting is needed, but should more generally allow for simpler control of the highlighting in runtime errors.Also removes
RuntimeErrorProducer#toHighlightin favour of these new methods.Target Minecraft Versions: any
Requirements: none
Related Issues: none