Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Since (annotation) - support multiple lines #7381

Merged
merged 10 commits into from
Jan 4, 2025

Conversation

ShaneBeee
Copy link
Contributor

@ShaneBeee ShaneBeee commented Jan 3, 2025

Description

This PR aims to add multi line support for the "Since" annotation.
I noticed lately some "since" lines are getting a little long, and are somewhat unreadable.
This change can make lines easier to read and decipher which version added what.
This will help further down the road also when more and more changes are done to a syntax.

Example of ExprName:
Screenshot 2025-01-02 at 6 30 26 PM

Example after Change:
Screenshot 2025-01-02 at 6 30 53 PM

As part of this PR, I changed since in ExprName (so we have a nice little example)

Bonus:

Fixed an issue with the "new" tag not showing up in docs when version doesn't fully match doc version.
ex: Skript version is 2.10.0, doc version is 2.10 (these weren't matching)


Target Minecraft Versions: any
Requirements: none
Related Issues: #7372

@Efnilite Efnilite added enhancement Feature request, an issue about something that could be improved, or a PR improving something. documentation Related to Skript's official documentation. labels Jan 3, 2025
@sovdeeth
Copy link
Member

sovdeeth commented Jan 3, 2025

i think i'm probably alone, but i find the current option more pleasing to read
I don't really have any objections to changing it, though.

@ShaneBeee
Copy link
Contributor Author

ShaneBeee commented Jan 3, 2025

i think i'm probably alone, but i find the current option more pleasing to read I don't really have any objections to changing it, though.

Just to note, you can still do a big ol long string if you want. It does not auto-split them.
I just found some of them (like ExprName) were getting a smidge unruly, and possibly in the future may get even more unruly.

Copy link
Member

@APickledWalrus APickledWalrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@Moderocky Moderocky merged commit 0ea39ac into SkriptLang:dev/feature Jan 4, 2025
5 checks passed
@ShaneBeee ShaneBeee deleted the shane/since-multi-line branch January 4, 2025 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Related to Skript's official documentation. enhancement Feature request, an issue about something that could be improved, or a PR improving something.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants