-
-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Since (annotation) - support multiple lines #7381
Since (annotation) - support multiple lines #7381
Conversation
i think i'm probably alone, but i find the current option more pleasing to read |
Co-authored-by: Patrick Miller <[email protected]>
Just to note, you can still do a big ol long string if you want. It does not auto-split them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
Description
This PR aims to add multi line support for the "Since" annotation.
I noticed lately some "since" lines are getting a little long, and are somewhat unreadable.
This change can make lines easier to read and decipher which version added what.
This will help further down the road also when more and more changes are done to a syntax.
Example of ExprName:
Example after Change:
As part of this PR, I changed since in ExprName (so we have a nice little example)
Bonus:
Fixed an issue with the "new" tag not showing up in docs when version doesn't fully match doc version.
ex: Skript version is 2.10.0, doc version is 2.10 (these weren't matching)
Target Minecraft Versions: any
Requirements: none
Related Issues: #7372