-
-
Notifications
You must be signed in to change notification settings - Fork 379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix tests running while world has not loaded #7379
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Efnilite
added
bug
An issue that needs to be fixed. Alternatively, a PR fixing an issue.
unit testing
For issues/PRs related to the Skript unit testing system.
labels
Jan 3, 2025
You'll need to get a non-spawn chunk. Everything is fine in the spawn chunks |
Moderocky
approved these changes
Jan 7, 2025
sovdeeth
approved these changes
Jan 9, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, ran the tests 2 extra times to double check
cheeezburga
approved these changes
Jan 9, 2025
cheeezburga
added
the
feature-ready
A PR/issue that has been approved, tested and can be merged/closed in the next feature version.
label
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
An issue that needs to be fixed. Alternatively, a PR fixing an issue.
feature-ready
A PR/issue that has been approved, tested and can be merged/closed in the next feature version.
unit testing
For issues/PRs related to the Skript unit testing system.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Makes tests run when the first chunk can be retrieved in the world, ensuring the world is loaded before the tests run.
Target Minecraft Versions: any
Requirements: none
Related Issues: none