Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wrong unknown nullability on suppress warning enum #7366

Merged
merged 5 commits into from
Jan 3, 2025
Merged

Fix wrong unknown nullability on suppress warning enum #7366

merged 5 commits into from
Jan 3, 2025

Conversation

TheLimeGlass
Copy link
Collaborator

Description

Fix wrong unknown nullability on suppress warning enum

Target Minecraft Versions: any
Requirements: none
Related Issues: none

sovdeeth
sovdeeth requested changes Jan 3, 2025
View reviewed changes
Copy link
Member

@sovdeeth sovdeeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to change your checked out branch of aliases to minimized-aliases

src/main/java/org/skriptlang/skript/lang/script/ScriptWarning.java Outdated Show resolved Hide resolved
src/main/java/org/skriptlang/skript/lang/script/ScriptWarning.java Outdated Show resolved Hide resolved
@TheLimeGlass TheLimeGlass requested a review from sovdeeth January 3, 2025 00:22
sovdeeth
sovdeeth approved these changes Jan 3, 2025
View reviewed changes
Copy link
Member

@sovdeeth sovdeeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems fine to me

@sovdeeth sovdeeth added the enhancement Feature request, an issue about something that could be improved, or a PR improving something. label Jan 3, 2025
Moderocky
Moderocky approved these changes Jan 3, 2025
View reviewed changes
Copy link
Member

@Moderocky Moderocky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good.

@Moderocky Moderocky merged commit 57e8fe5 into SkriptLang:dev/feature Jan 3, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Efnilite Efnilite Efnilite approved these changes

@Moderocky Moderocky Moderocky approved these changes

@sovdeeth sovdeeth sovdeeth approved these changes

Assignees
No one assigned
Labels
enhancement Feature request, an issue about something that could be improved, or a PR improving something.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TheLimeGlass @sovdeeth @Moderocky @Efnilite