Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Villager expression updates #7352

Merged

Conversation

ShaneBeee
Copy link
Contributor

@ShaneBeee ShaneBeee commented Jan 1, 2025

Description

This PR aims to add zombie villagers to the villager expressions for type/profession.
I didnt realize this existed until I saw @TheAbsolutionism's recent PR

And in case you're wondering, no these dude's don't have a level/experience.


Target Minecraft Versions: any
Requirements: none
Related Issues: none

@TheAbsolutionism
Copy link
Contributor

Mine is different, not unless you initially planned something else.

@ShaneBeee
Copy link
Contributor Author

Mine is different, not unless you initially planned something else.

no no, I was just meaning I had no clue zombie villager's had separate API for their type/profession, until I saw your PR and I was like, OH CRAP.

@TheAbsolutionism
Copy link
Contributor

no no, I was just meaning I had no clue zombie villager's had separate API for their type/profession, until I saw your PR and I was like, OH CRAP.

ohhhh, they're about the same, difference is just the codenames and them being ZombieVillagers lol

@APickledWalrus APickledWalrus added enhancement Feature request, an issue about something that could be improved, or a PR improving something. 2.10 Targeting a 2.10.X version release labels Jan 1, 2025
@APickledWalrus APickledWalrus merged commit 9c6cae0 into SkriptLang:dev/feature Jan 1, 2025
5 checks passed
@ShaneBeee ShaneBeee deleted the shane/villager-zombie branch January 1, 2025 22:38
Moderocky pushed a commit that referenced this pull request Jan 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.10 Targeting a 2.10.X version release enhancement Feature request, an issue about something that could be improved, or a PR improving something.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants