Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed command tab complete not scanning softlink folders #7186

Open
wants to merge 15 commits into
base: dev/feature
Choose a base branch
from

Conversation

killertuling
Copy link

…r, it will not be accessed

Description

Fixed where tab complet would not scan for .sk files within symlinked directories under the scripts folder.
This PR resolves the problem of not being able to scan these directories.
I have tested it, and after the modification, symlinked directories can be accessed normally.
The operating system I used is Ubuntu Server 24.04.


Target Minecraft Versions: any
Requirements: none
Related Issues: none

@killertuling killertuling changed the title Fixed when using tab complet, if the target is a Linux softlink folde… Fixed tab complet not scan softlink folder Nov 3, 2024
@Romitou Romitou added the enhancement Feature request, an issue about something that could be improved, or a PR improving something. label Nov 3, 2024
@Efnilite Efnilite requested a review from sovdeeth November 4, 2024 15:14
* SoundUtils - handle Sound class for enum/interface

* SoundUtils - fix an error with MC 1.15

* EffPlaySound.sk - add simple test to make sure syntax doesn't throw error

* EffPlaySound - remove reflection and remove to effect class

* EffPlaySound - some changes

* EffPlaySound.sk - fix tests failing
@Efnilite Efnilite added the feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. label Nov 12, 2024
@Efnilite Efnilite changed the title Fixed tab complet not scan softlink folder Fixed command tab complete not scanning softlink folders Nov 12, 2024
sovdeeth and others added 5 commits November 22, 2024 23:09
* catch long overflows

* don't compromise with precision

uses Math.xExact code to catch overflows instead of relying on doubles.

* Apply suggestions from code review

Co-authored-by: Efnilite <[email protected]>

---------

Co-authored-by: Efnilite <[email protected]>
* handle invalid regex patterns

* missing space in toString

Co-authored-by: Efnilite <[email protected]>

---------

Co-authored-by: Efnilite <[email protected]>
Co-authored-by: sovdee <[email protected]>
* require skull texture lookup on paper servers

* 1.19.4+
…r method for changing expressions. (SkriptLang#7120)

* changeInPlace, fix indices being overwritten, regr tests

* can't count

* requested changes

* Apply suggestions from code review

Co-authored-by: Patrick Miller <[email protected]>

---------

Co-authored-by: Patrick Miller <[email protected]>
@Efnilite
Copy link
Member

branch needs to be updated before this can be merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature request, an issue about something that could be improved, or a PR improving something. feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants