Fix ExprBookAuthors performance Java 17 #7023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheLimeGlass
added
the
enhancement
APickledWalrus
requested changes
Sep 1, 2024
Moderocky
reviewed
Sep 1, 2024
Co-authored-by: Moderocky <[email protected]>
APickledWalrus
approved these changes
Sep 1, 2024
Co-authored-by: Patrick Miller <[email protected]>
Co-authored-by: sovdee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
During a profiler, I noticed book author expression was a hotspot class during Skript tests at (3.60ms 72.4%) after adapting the class to Java 17 pattern matching, it has been reduced to (1.31ms 44.8%)
Target Minecraft Versions: any
Requirements: none
Related Issues: none