Timespan <-> Duration Conversion methods. #6993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fusezion
approved these changes
Aug 22, 2024
|
But wait! It gets better!! A lot of the Java 8 time stuff is an interface (designed for overrides from the SQL library) so I implemented them (based on built-in Duration and ChronoUnit) and so Skript's Timespan class should now be usable in a lot of Java & API time-related methods as-is. Of course there is the caveat that Skript months are all 30 days but I don't think that's a major drawback. |
APickledWalrus
approved these changes
Aug 22, 2024
APickledWalrus
added
the
enhancement
Moderocky
force-pushed
the
timespan-to-duration
branch
from
c86c936 to
fb243e4
Compare
UnderscoreTud
approved these changes
Aug 30, 2024
Moderocky
added
the
feature-ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds two simple converter methods for Skript Timespan <-> Java Duration.
Duration is the common Java timespan class, which is probably more useful to addon developers.
Since the direct milliseconds method in Timespan was deprecated and the replacement requires a few more steps to use, I thought it would be nice to have a converter for anybody wanting durations for external API.