-
-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add teleport flags #6498
Add teleport flags #6498
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⚡
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a good feature to support, but I'm a little worried that this implementation is a little more complicated than it has to be. The syntax seems good for users, but the implementation feels a little hard to reason around because there are so many methods with the same name and, in my opinion, some methods are in odd places.
The usage of the functional interface allows for keeping a dynamic calling, and also exactly as you said. There are very similar methods with similar parameters which is the exact purpose of a functional interface. This can easily be expanded apon to add support for TeleportCauseEvent if and when needed, as there are also those methods in the Entity class. |
…ass/Skript into feature/teleport-flags
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good!
Co-authored-by: sovdee <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, just about done. Re-request for an approval 🙂
…ass/Skript into feature/teleport-flags
--------- Co-authored-by: sovdee <[email protected]> Co-authored-by: Moderocky <[email protected]>
Description
Adds Paper's TeleportFlags in 1.19+
Allows to retain location, passengers, x-coordinate etc, during a teleportation.
Target Minecraft Versions: Paper 1.19+
Requirements: Paper 1.19+
Related Issues: #6119