Fixes an exception from being thrown on async events #5699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheLimeGlass
added
the
bug
AyhamAl-Ali
approved these changes
Jul 14, 2023
sovdeeth
approved these changes
Sep 6, 2023
APickledWalrus
requested changes
Sep 8, 2023
… into fix/async-events
… into fix/async-events
APickledWalrus
approved these changes
Sep 9, 2023
AyhamAl-Ali
pushed a commit
to AyhamAl-Ali/Skript
that referenced
this pull request
Sep 9, 2023
Moderocky
added a commit
that referenced
this pull request
Sep 9, 2023
Fixes an exception from being thrown on async events (#5699) Co-authored-by: LimeGlass <[email protected]> Co-authored-by: Moderocky <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
An exception gets thrown when attempting to execute a required synchronous task like setting a block or executing a console command on an asynchronous event.
Because of this, i've added an override-able method in SkriptEvent for API developers to change how it performs, and should acknowledge that it then becomes the users fault for exceptions when running an asynchronous event with synchronous executes.
I literally have no clue how this was not caught sooner. I wonder if Paper has started throwing exceptions rather than silent. I could not reproduce the issue, but this solution will work.
JUnit tests currently fail, because there is a loss of context bug that is fixed in #5219 waiting on that merge before continuing.
Target Minecraft Versions: any
Requirements: none
Related Issues: #5689