fix: 🐛 return undefined if a corresponding dir opr hier can't be foun…

…d for a field
SkepticMystic · Jan 21, 2022 · 013e161 · 013e161
1 parent fdc4228
commit 013e161
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 20 deletions.
diff --git a/main.js b/main.js
@@ -4871,6 +4871,8 @@ function getOppFields(userHiers, field) {
     if (field.endsWith(">"))
         return field.slice(0, -4);
     const { fieldHier, fieldDir } = getFieldInfo(userHiers, field);
+    if (!fieldHier || !fieldDir)
+        return undefined;
     const oppDir = getOppDir(fieldDir);
     return fieldHier[oppDir];
 }
@@ -25173,16 +25175,9 @@ async function drawTrail(plugin) {
             db.end2G();
             return;
         }
-        let view;
-        let livePreview = false;
-        if (mode === "preview") {
-            view = activeMDView.previewMode.containerEl.querySelector("div.markdown-preview-view");
-        }
-        else {
-            view = activeMDView.contentEl.querySelector("div.markdown-source-view");
-            if (view.hasClass("is-live-preview"))
-                livePreview = true;
-        }
+        const view = mode === "preview"
+            ? activeMDView.previewMode.containerEl.querySelector("div.markdown-preview-view")
+            : activeMDView.contentEl.querySelector("div.markdown-source-view");
         (_c = activeMDView.containerEl
             .querySelectorAll(".BC-trail")) === null || _c === void 0 ? void 0 : _c.forEach((trail) => trail.remove());
         const closedUp = getLimitedTrailSub(plugin);

diff --git a/src/Views/TrailView.ts b/src/Views/TrailView.ts
@@ -42,6 +42,13 @@ function getLimitedTrailSub(plugin: BCPlugin) {
   return getSubInDirs(closed, "up");
 }
 
+function getGraphForTrail(plugin: BCPlugin) {
+  const { closedG } = plugin;
+  const { userHiers, limitTrailCheckboxes } = plugin.settings;
+
+  closedG;
+}
+
 function getBreadcrumbs(
   settings: BCSettings,
   g: MultiGraph,
@@ -140,16 +147,12 @@ export async function drawTrail(plugin: BCPlugin): Promise<void> {
       return;
     }
 
-    let view: HTMLElement;
-    let livePreview: boolean = false;
-    if (mode === "preview") {
-      view = activeMDView.previewMode.containerEl.querySelector(
-        "div.markdown-preview-view"
-      );
-    } else {
-      view = activeMDView.contentEl.querySelector("div.markdown-source-view");
-      if (view.hasClass("is-live-preview")) livePreview = true;
-    }
+    const view =
+      mode === "preview"
+        ? activeMDView.previewMode.containerEl.querySelector(
+            "div.markdown-preview-view"
+          )
+        : activeMDView.contentEl.querySelector("div.markdown-source-view");
 
     activeMDView.containerEl
       .querySelectorAll(".BC-trail")

diff --git a/src/graphUtils.ts b/src/graphUtils.ts
@@ -186,6 +186,7 @@ export function getOppFields(userHiers: UserHier[], field: string) {
   // If the field ends with `>`, it is already the opposite field we need (coming from getOppFallback`)
   if (field.endsWith(">")) return field.slice(0, -4);
   const { fieldHier, fieldDir } = getFieldInfo(userHiers, field);
+  if (!fieldHier || !fieldDir) return undefined;
   const oppDir = getOppDir(fieldDir);
   return fieldHier[oppDir];
 }