Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add vault #36

Merged
merged 5 commits into from
Jun 18, 2020
Merged

Add vault #36

merged 5 commits into from
Jun 18, 2020

Conversation

zhenik
Copy link
Contributor

@zhenik zhenik commented Jun 17, 2020

No description provided.

@zhenik zhenik requested a review from fredrikhgrelland June 17, 2020 08:18
@zhenik zhenik added the type/enhancement New feature or request label Jun 17, 2020
@zhenik zhenik self-assigned this Jun 17, 2020
@zhenik zhenik linked an issue Jun 17, 2020 that may be closed by this pull request
Setup Vault #21
Closed
@zhenik
Copy link
Contributor Author

zhenik commented Jun 17, 2020 •
edited
Loading

Some notes:

  • vault server dev - uses inmem (in-memory) backend. reference, so we need to run vault server, init and unseal vault, if we want to use consul as a backend

@fredrikhgrelland
Copy link
Contributor

@zhenik why would we want persistent backend? consul and nomad are also inmem.

@zhenik
Copy link
Contributor Author

zhenik commented Jun 18, 2020

@zhenik why would we want persistent backend? consul and nomad are also inmem.

I thought we need to have integration Vault with Consul?

@fredrikhgrelland
Copy link
Contributor

@zhenik why would we want persistent backend? consul and nomad are also inmem.

I thought we need to have integration Vault with Consul?
Yes, but as a secret backend. ( meaning vault will handle ACL ) https://www.vaultproject.io/docs/secrets/consul

@zhenik
Copy link
Contributor Author

zhenik commented Jun 18, 2020

So, vault dev mode will be sufficient then for our needs?

fredrikhgrelland
fredrikhgrelland reviewed Jun 18, 2020
View reviewed changes
ansible/templates/vault.service.j2 Outdated Show resolved Hide resolved
ansible/templates/vault.hcl.j2 Outdated Show resolved Hide resolved
fredrikhgrelland
fredrikhgrelland approved these changes Jun 18, 2020
View reviewed changes
ansible/templates/vault.hcl.j2 Outdated Show resolved Hide resolved
ansible/templates/vault.hcl.j2 Outdated Show resolved Hide resolved
ansible/templates/vault.hcl.j2 Outdated Show resolved Hide resolved
@zhenik zhenik mentioned this pull request Jun 18, 2020
Closed
@zhenik zhenik changed the title Add vault [WIP] Add vault Jun 18, 2020
@zhenik zhenik marked this pull request as ready for review June 18, 2020 11:38
@zhenik zhenik added this to the 0.1 milestone Jun 18, 2020
@pdmthorsrud pdmthorsrud mentioned this pull request Jun 18, 2020
Merged
fredrikhgrelland
fredrikhgrelland approved these changes Jun 18, 2020
View reviewed changes
Copy link
Contributor

@fredrikhgrelland fredrikhgrelland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prestart will be addressed in #20

@fredrikhgrelland fredrikhgrelland merged commit dd2873c into Skatteetaten:master Jun 18, 2020
@zhenik zhenik deleted the feature/vault branch June 18, 2020 12:47
@zhenik
Copy link
Contributor Author

zhenik commented Jun 18, 2020

ref to update config:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredrikhgrelland fredrikhgrelland fredrikhgrelland approved these changes

Assignees

@zhenik zhenik

Labels
type/enhancement New feature or request
Projects
None yet
Milestone
0.1
Development

Successfully merging this pull request may close these issues.

Setup Vault
2 participants
@zhenik @fredrikhgrelland