Skip to content
This repository has been archived by the owner on Jan 18, 2020. It is now read-only.

Increase netstandard support to v1.3 #54

Merged
merged 4 commits into from
Oct 15, 2018
Merged

Increase netstandard support to v1.3 #54

merged 4 commits into from
Oct 15, 2018

Conversation

iamcarbon
Copy link
Contributor

@iamcarbon iamcarbon commented Oct 15, 2018

Increases netstandard target from v1.1 to v1.3.

@@ -1,23 +0,0 @@
using System.Reflection;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NICE!

@@ -3,15 +3,7 @@
<PropertyGroup>
<VersionPrefix>0.0.0</VersionPrefix>
<TargetFramework>netcoreapp2.1</TargetFramework>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering if we need both 1.1 and 2.1 here. Are we testing the 1.3 code?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should double check all our projects actually and make sure we are testing with the following.

<TargetFramework>net462;net471;netcoreapp2.1<\TargetFramework>

Separate PR's though I'd say.

@JimBobSquarePants JimBobSquarePants merged commit 1f4224f into SixLabors:master Oct 15, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants