Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix thresholds for Resize kernel tests #2440

Merged
merged 2 commits into from
Apr 23, 2023
Merged

Conversation

brianpopow
Copy link
Collaborator

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

This PR fixes the thresholds for the resize kernel tests, which #2414 revealed.
The resize kernel uses FMA, which can have slightly different results the scalar version.
For more details see discussion: #1513 (comment)

Also adds a scalar version of test PngDecoder_Decode_Resize()

Copy link
Member

@JimBobSquarePants JimBobSquarePants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah great! Thanks for this 👍

@JimBobSquarePants JimBobSquarePants merged commit 7d0bbbd into main Apr 23, 2023
@JimBobSquarePants JimBobSquarePants deleted the bp/ResizeKernelTests branch April 23, 2023 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants