Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove return value documentation for void return types. #1915

Merged
merged 1 commit into from
Dec 30, 2021

Conversation

wischi-chr
Copy link
Contributor

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

Very minor code documentation fixes.

@CLAassistant
Copy link

CLAassistant commented Dec 29, 2021

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@dlemstra dlemstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tnx for fixing this for us.

@JimBobSquarePants
Copy link
Member

Needs to be fixed at the template level.

https://github.com/SixLabors/ImageSharp/blob/master/src/ImageSharp/Formats/ImageExtensions.Save.tt

@wischi-chr
Copy link
Contributor Author

Should I change it only in the template or in both files?

@dlemstra
Copy link
Member

dlemstra commented Dec 30, 2021

Both files should be changed, I completely missed that.

@wischi-chr
Copy link
Contributor Author

The patch now includes the fix in the template as well.

@codecov
Copy link

codecov bot commented Dec 30, 2021

Codecov Report

Merging #1915 (ba73add) into master (1adb6b4) will increase coverage by 0%.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1915   +/-   ##
======================================
  Coverage      87%     87%           
======================================
  Files         961     961           
  Lines       51034   51034           
  Branches     6324    6324           
======================================
+ Hits        44789   44793    +4     
+ Misses       5204    5202    -2     
+ Partials     1041    1039    -2     
Flag Coverage Δ
unittests 87% <ø> (+<1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/ImageSharp/Formats/ImageExtensions.Save.cs 94% <ø> (ø)
...emory/DiscontiguousBuffers/MemoryGroup{T}.Owned.cs 89% <0%> (+5%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1adb6b4...ba73add. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants