Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unified jpeg benchmark #1844

Merged
merged 3 commits into from
Nov 21, 2021
Merged

Conversation

br3aker
Copy link
Contributor

@br3aker br3aker commented Nov 21, 2021

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

This PR adds 'unified' jpeg decoder benchmark with different kinds of jpeg images for somewhat baseline performance comparison of new code/optimizations. I've mainly used already existing images for this benchmark it by no means has all of different jpeg kinds - no progressive 4:4:4 for example. Benchmark image collection should naturally grow over time.

I've also restructured formats behcmarks folder to this instead of a one big folder of all formats benchmarks:
image

@codecov
Copy link

codecov bot commented Nov 21, 2021

Codecov Report

Merging #1844 (e143093) into master (413c90c) will increase coverage by 0%.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1844   +/-   ##
======================================
  Coverage      87%     87%           
======================================
  Files         937     937           
  Lines       48420   48420           
  Branches     6054    6054           
======================================
+ Hits        42324   42325    +1     
+ Misses       5094    5093    -1     
  Partials     1002    1002           
Flag Coverage Δ
unittests 87% <ø> (+<1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ageSharp/Formats/Webp/Lossless/PredictorEncoder.cs 97% <0%> (-1%) ⬇️
...mageSharp/Formats/Webp/Lossless/NearLosslessEnc.cs 100% <0%> (+3%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 413c90c...e143093. Read the comment docs.

Copy link
Member

@JimBobSquarePants JimBobSquarePants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea 👍

@JimBobSquarePants JimBobSquarePants merged commit a8de2ec into SixLabors:master Nov 21, 2021
@br3aker br3aker deleted the jpeg-benchmark branch November 21, 2021 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants