Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unittest for net6 bug #1766

Merged
merged 6 commits into from
Sep 25, 2021
Merged

Add unittest for net6 bug #1766

merged 6 commits into from
Sep 25, 2021

Conversation

synercoder
Copy link
Contributor

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

A regression test for #1765, #1704 & #1707 as proposed to @antonfirsov in #1765.

@synercoder
Copy link
Contributor Author

@antonfirsov could you provide me with a clue where I went wrong? I added the file, added the test. Test works on my end... But it seems that automated build can't find the file.

@synercoder
Copy link
Contributor Author

Test running again... just thought that it might be a capital letter in path issue might be. Windows doesn't care... but Ubuntu might...

@synercoder
Copy link
Contributor Author

@antonfirsov could you provide me with a clue where I went wrong? I added the file, added the test. Test works on my end... But it seems that automated build can't find the file.

I know where I went wrong... it was indeed the uppercase/lowercase issue in the path.

@codecov
Copy link

codecov bot commented Sep 22, 2021

Codecov Report

Merging #1766 (b055e8b) into master (2b85b55) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1766   +/-   ##
=======================================
  Coverage   84.52%   84.52%           
=======================================
  Files         846      846           
  Lines       37213    37213           
  Branches     4370     4370           
=======================================
  Hits        31455    31455           
  Misses       4904     4904           
  Partials      854      854           
Flag Coverage Δ
unittests 84.52% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b85b55...b055e8b. Read the comment docs.

Copy link
Member

@antonfirsov antonfirsov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants