Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Colourful from 2.0.5 to 3.0.0 (only benchmarks affected) #1691

Merged
merged 1 commit into from
Jul 12, 2021

Conversation

tompazourek
Copy link
Contributor

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

The Colourful library is used in the benchmarks, and recently, there was a version 3.0.0 released. I updated the package reference, and the converter code to reflect the new API.

@CLAassistant
Copy link

CLAassistant commented Jul 9, 2021

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Jul 9, 2021

Codecov Report

Merging #1691 (7a342a1) into master (fe65a38) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1691   +/-   ##
=======================================
  Coverage   84.33%   84.33%           
=======================================
  Files         816      816           
  Lines       35908    35908           
  Branches     4173     4173           
=======================================
  Hits        30282    30282           
  Misses       4804     4804           
  Partials      822      822           
Flag Coverage Δ
unittests 84.33% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe65a38...7a342a1. Read the comment docs.

@JimBobSquarePants
Copy link
Member

Ah fantastic @tompazourek thanks for this!

Did you run the benchmarks? Any changes?

@JimBobSquarePants JimBobSquarePants merged commit c7f6115 into SixLabors:master Jul 12, 2021
@tompazourek
Copy link
Contributor Author

@JimBobSquarePants I ran the benchmarks locally and noticed that Colourful performed a bit better than before. I think in one case (I think it was the Lab conversion), it might even have outperformed the current ImageSharp solution.

@JimBobSquarePants
Copy link
Member

@tompazourek Nice work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants