Code

Fixed Issue#1628#1629

Code

Merged

JimBobSquarePants merged 23 commits intoSixLabors:masterSixLabors/ImageSharp:masterfrom br3aker:image-disposed-fixbr3aker/ImageSharp:image-disposed-fixCopy head branch name to clipboardJun 2, 2021

+375-57

Commits

Commits on May 13, 2021

• Image<TPixel>.Frames now properly throws ObjectDisposedException after being disposed

  

  Dmitry Pentin

  committed
  7900b43

• Image<TPixel> private methods no longer check if object was disposed - it is done at public method calls

  

  Dmitry Pentin

  committed
  d48b152

• Image<TPixel> private property PixelSource no longer checks if object was disposed, check is delegated to public methods using that property

  

  Dmitry Pentin

  committed
  7029b2f

• Removed GC.SuppressFinalize(this) from Image.Dispose() due to it not having a Finalization method

  

  Dmitry Pentin

  committed
  1c45c1a

• Added tests for issue#1628

  

  Dmitry Pentin

  committed
  095ce41

• Moved dispose control logic to base Image class

  Show description for acf9d85
  

  Dmitry Pentin

  committed
  acf9d85

• Removed redundant flag from Image.Dispose(bool) call

  Show description for 8ec1013
  

  Dmitry Pentin

  committed
  8ec1013

• Removed invalid tests

  Show description for ff4b269
  

  Dmitry Pentin

  committed
  ff4b269

Commits on May 14, 2021

• ImageFrameCollection now properly implements IDisposable interface & ensures all operations are called on valid object

  

  Dmitry Pentin

  committed
  cbca565

• All ImageFrameCollection<TPixel> public properties & method now check if object was disposed

  

  Dmitry Pentin

  committed
  127e9dd

• Added internal accessor for root frame

  

  Dmitry Pentin

  committed
  3f8bd3d

• Added tests for issues#1628

  

  Dmitry Pentin

  committed
  009e935

• Fixed couple of invalid tests for ImageFrameCollection<TPixel>

  

  Dmitry Pentin

  committed
  f0f0c08

• ImageFrameCollection.Contains first checks if it was disposed first

  

  Dmitry Pentin

  committed
  a71ce19

• Fixed a couple of failing tests

  

  Dmitry Pentin

  committed
  f561053

Commits on May 18, 2021

• Merge branch 'master' into image-disposed-fix

  JimBobSquarePants

  authored
  34706fb

Commits on May 21, 2021

• Renamed private Image<TPixel>.PixelSourse to PixelSourceUnsafe

  

  Dmitry Pentin

  committed
  1c8dcef

• Implemented dispose method according to common convention.

  

  Dmitry Pentin

  committed
  e787ffa

• Fixed disposable resouce leak in unit test.

  

  Dmitry Pentin

  committed
  d54ff0e

• Implemented ThrowObjectDisposedException for the ThrowHelper, replaced raw throws with this in Image/ImageFrameCollection

  

  Dmitry Pentin

  committed
  5704403

Commits on Jun 2, 2021

• Fix throwhelper

  JimBobSquarePants

  committed
  65808ae

• Merge branch 'master' into pr/1629

  JimBobSquarePants

  committed
  5d2884e

• Make frames resonly

  JimBobSquarePants

  committed
  afee881