Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image.Load(byte[]) should return non-generic Image #1573

Merged
merged 2 commits into from
Mar 9, 2021

Conversation

antonfirsov
Copy link
Member

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

Discovered an API bug while answering #1571. The fix is a breaking change, but very scoped one.

@antonfirsov antonfirsov added API breaking Signifies a binary breaking change. labels Mar 9, 2021
@codecov
Copy link

codecov bot commented Mar 9, 2021

Codecov Report

Merging #1573 (583bb6b) into master (36018bd) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1573   +/-   ##
=======================================
  Coverage   83.65%   83.65%           
=======================================
  Files         746      746           
  Lines       32991    32991           
  Branches     3680     3680           
=======================================
  Hits        27597    27597           
  Misses       4680     4680           
  Partials      714      714           
Flag Coverage Δ
unittests 83.65% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/ImageSharp/Image.FromBytes.cs 93.90% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36018bd...583bb6b. Read the comment docs.

Copy link
Member

@JimBobSquarePants JimBobSquarePants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find!

@JimBobSquarePants JimBobSquarePants merged commit ae8e5e4 into master Mar 9, 2021
@JimBobSquarePants JimBobSquarePants deleted the af/fix-overload branch March 9, 2021 17:04
@JimBobSquarePants JimBobSquarePants changed the title Image.Load(byte[]) should return non-generic Image Image.Load(byte[]) should return non-generic Image Sep 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API breaking Signifies a binary breaking change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants