Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add xunit trait attributes to tests #1455

Merged
merged 1 commit into from
Dec 3, 2020
Merged

Add xunit trait attributes to tests #1455

merged 1 commit into from
Dec 3, 2020

Conversation

brianpopow
Copy link
Collaborator

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

I have added xunit traits attribute to the tests. I think this makes it easier to filter for specific tests. For example to run only tests for a specific format:

dotnet test -c Debug -f netcoreapp3.1 --filter "Format=Png"

Also you can filter by traits in the test explorer:

traits

@brianpopow brianpopow requested a review from a team December 3, 2020 06:26
@codecov
Copy link

codecov bot commented Dec 3, 2020

Codecov Report

Merging #1455 (455088e) into master (2ffc4e8) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1455   +/-   ##
=======================================
  Coverage   83.66%   83.66%           
=======================================
  Files         736      736           
  Lines       32012    32012           
  Branches     3609     3609           
=======================================
  Hits        26782    26782           
  Misses       4516     4516           
  Partials      714      714           
Flag Coverage Δ
unittests 83.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14c541c...455088e. Read the comment docs.

Copy link
Member

@antonfirsov antonfirsov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@brianpopow brianpopow merged commit 5ab768c into master Dec 3, 2020
@brianpopow brianpopow deleted the bp/xunittraits branch December 3, 2020 10:11
JimBobSquarePants pushed a commit that referenced this pull request Mar 13, 2021
Add xunit trait attributes to tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants