-
-
Notifications
You must be signed in to change notification settings - Fork 852
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure Span length of source and destination are equal during pixel conversion #1443
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1443 +/- ##
=======================================
Coverage 83.68% 83.69%
=======================================
Files 734 734
Lines 31990 31995 +5
Branches 3605 3605
=======================================
+ Hits 26772 26777 +5
Misses 4505 4505
Partials 713 713
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
This shouldn't be the case, the |
Aha! I actually had to do a hack to allow for this in a debug check. 1ad9fcd#diff-ba27a760948c3e593e3ac6a18ad7b8ea04bc0255376575088b7fad70814040e3R227-R231 Yep. Slicing is probably wise. |
i will leave this as it is now. Maybe someone should give a quick review of 7c77e7e again |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Ensure Span length of source and destination are equal during pixel conversion
Prerequisites
Description
As reported in #1442, there are some failing tests in the master branch. The reason for this is a
Debug.Guard
which ensures the span length are equal during pixel conversion. Sometimes the source span was smaller the the destination. This got unnoticed during Release CI runs.