Enable support to use libgdiplus library on macOS (splitted) #1424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@antonfirsov - lets start with tiny small and clean changes. This PR contains just fix for |
Codecov Report
@@ Coverage Diff @@
## master #1424 +/- ##
=======================================
Coverage 83.08% 83.08%
=======================================
Files 707 707
Lines 31839 31839
Branches 3590 3590
=======================================
Hits 26454 26454
Misses 4668 4668
Partials 717 717
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
antonfirsov
approved these changes
Nov 15, 2020
There was a problem hiding this comment.
Looks good, but I'm not really familiar with workflows stuff. @JimBobSquarePants can you spot anything wrong?
JimBobSquarePants
approved these changes
Nov 15, 2020
4 tasks
4 tasks
JimBobSquarePants
added a commit
that referenced
this pull request
Mar 13, 2021
Enable support to use libgdiplus library on macOS (splitted)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Unable to load DLL 'libgdiplus')Related to #1338EDIT by @antonfirsov fixes #1387Based on discussion in PR: #1403