Js/faster cache hash #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A reminder that I can run benchmarks for any branch, under load (lin/win and cloud/physical). I can give you the numbers for this one if you want. And I can also get you perfview traces if necessary. |
|
@sebastienros I meant to tag you when I pushed this actually. Thanks! That would be really great. |
|
@sebastienros Did you ever get the chance to benchmark this? I'd like to merge it in so we can release an updated version for consumption. |
|
Should do it tomorrow |
|
I'm gonna merge this, we can benchmark later. Super confident it's faster anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
Optimization to half the memory usage and speed up the performance of the hashing algorithm.