Remove nullable disable from azure #309
Conversation
* Removed all Nullable disable from the azure providers * Removed IAzureBlobContainerClientOptions because it wasn't used just for declaration * Added convenience DI methods for Adding the cache or image provider. Leaving out the initialization was on purpose to not run that code on startup because it could throw an exception so the app won't start..
stefannikolei
force-pushed
the
stefannikolei/nullable/azure
branch
from
28be64d to
11cc34c
Compare
Codecov Report
@@ Coverage Diff @@
## main #309 +/- ##
===================================
- Coverage 85% 85% -1%
===================================
Files 77 78 +1
Lines 2192 2199 +7
Branches 304 308 +4
===================================
- Hits 1879 1877 -2
- Misses 229 235 +6
- Partials 84 87 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
| /// <summary> | ||
| /// Extension methods for <see cref="IServiceCollection"/> to simplify middleware service registration. | ||
| /// </summary> | ||
| public static class SeviceCollectionExtensions |
There was a problem hiding this comment.
I don't think we need these extensions. I'd rather we kept the API consistent across all provider types.
There was a problem hiding this comment.
Ok. Gonna remove that file again. But I think that there is a error on the website.
This must be .SetCache<Adblob..>() or am I missing something?
There was a problem hiding this comment.
The < > tags were not HTML encoded. Have updated them now thanks.
Prerequisites
Description