Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aws s3 client timeout #287

Merged
merged 3 commits into from
Sep 29, 2022

Conversation

mdupras
Copy link
Contributor

@mdupras mdupras commented Sep 26, 2022

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

Most configurations of the S3Client can be set via environment variable, but it is not the case for the Timeout settings. I've only added a config and forwarded it.

@mdupras mdupras force-pushed the aws-s3-client-timeout branch from c79287b to 0823d89 Compare September 26, 2022 17:53
@codecov
Copy link

codecov bot commented Sep 26, 2022

Codecov Report

Merging #287 (0823d89) into main (7e41144) will decrease coverage by 0%.
The diff coverage is 75%.

@@         Coverage Diff         @@
##           main   #287   +/-   ##
===================================
- Coverage    85%    85%   -1%     
===================================
  Files        76     76           
  Lines      2165   2173    +8     
  Branches    303    304    +1     
===================================
+ Hits       1851   1857    +6     
- Misses      229    231    +2     
  Partials     85     85           
Flag Coverage Δ
unittests 85% <75%> (-1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...geSharp.Web.Providers.AWS/AmazonS3ClientFactory.cs 31% <66%> (+16%) ⬆️
....Providers.AWS/Caching/AWSS3StorageCacheOptions.cs 85% <100%> (+2%) ⬆️
....AWS/Providers/AWSS3StorageImageProviderOptions.cs 87% <100%> (+1%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@JimBobSquarePants JimBobSquarePants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for your help here!

@JimBobSquarePants JimBobSquarePants merged commit d8c16d4 into SixLabors:main Sep 29, 2022
@mdupras mdupras deleted the aws-s3-client-timeout branch September 29, 2022 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants