Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-add AutoOrientWebProcessor #260

Merged
merged 2 commits into from
May 7, 2022
Merged

Re-add AutoOrientWebProcessor #260

merged 2 commits into from
May 7, 2022

Conversation

brianpopow
Copy link
Contributor

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

As discussed in #259: This PR re-adds AutoOrientWebProcessor

@codecov
Copy link

codecov bot commented May 6, 2022

Codecov Report

Merging #260 (654003f) into main (ba216da) will increase coverage by 0%.
The diff coverage is 88%.

@@         Coverage Diff         @@
##           main   #260   +/-   ##
===================================
  Coverage    85%    85%           
===================================
  Files        74     75    +1     
  Lines      2028   2036    +8     
  Branches    297    298    +1     
===================================
+ Hits       1734   1741    +7     
- Misses      210    211    +1     
  Partials     84     84           
Flag Coverage Δ
unittests 85% <88%> (+<1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ageSharp.Web/Processors/WebProcessingExtensions.cs 100% <ø> (ø)
...mageSharp.Web/Processors/AutoOrientWebProcessor.cs 85% <85%> (ø)
...DependencyInjection/ServiceCollectionExtensions.cs 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba216da...654003f. Read the comment docs.

Copy link
Member

@JimBobSquarePants JimBobSquarePants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants