Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JSS][React] SitecoreContextReactContext.Provider is not working properly, because value never changes as it is always same class instance #983

Merged
merged 1 commit into from
Apr 28, 2022

Conversation

illiakovalenko
Copy link
Contributor

@illiakovalenko illiakovalenko commented Apr 15, 2022

Description / Motivation

Testing Details

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

…erly, because value never changes as it is always same class instance
@illiakovalenko illiakovalenko requested a review from a team April 15, 2022 06:47
Copy link
Contributor

@addy-pathania addy-pathania left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@illiakovalenko illiakovalenko merged commit 7b65d25 into release/12.0.0 Apr 28, 2022
@illiakovalenko illiakovalenko deleted the hotfix/526200 branch April 28, 2022 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants