[Nextjs] Make extractPath shared and remove duplicate page-props-factory/plugins/normalMode for personalize addon
#954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…actory/plugins/normalMode` for `personalize` addon
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/sitecore-jss/edge-e2e-styleguide/6WSknBPxypNAdAA7NHXRBAm2bk2i [Deployment for 604c0e3 failed] |
ambrauer
approved these changes
Mar 17, 2022
There was a problem hiding this comment.
Looks great. Just one thing noticed (not limited to this feature): we've broken away from our file naming conventions recently. We were using kebab case for .ts files and now have started mixing in camel case. For this PR, it would be extract-path.ts. But we might also want to fix our plugins (e.g. normal-mode.ts).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description / Motivation
extractPathsharedpage-props-factory/plugins/normalModeforpersonalizeaddonpage-props-factory/extractPath.tsis created and uses default file replacement and diff approachTesting Details
Types of changes