-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Initializer] Personalize Initializer Add-on #939
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/sitecore-jss/edge-e2e-styleguide/3QFgJ9ekKpC7bRfWB7Q2cCJ1gnQb [Deployment for 038b601 failed] |
...es/create-sitecore-jss/src/templates/nextjs/src/lib/page-props-factory/plugins/normalMode.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments. Beyond this, I'm seeing a lot of files that are OOTB with either the base or nextjs-styleguide add-on initializers. Any of those should be removed here.
packages/create-sitecore-jss/src/initializers/nextjs-personalize/index.ts
Outdated
Show resolved
Hide resolved
packages/create-sitecore-jss/src/templates/nextjs-personalize/README.md
Outdated
Show resolved
Hide resolved
packages/create-sitecore-jss/src/templates/nextjs-personalize/package.json
Outdated
Show resolved
Hide resolved
...es/create-sitecore-jss/src/templates/nextjs/src/lib/page-props-factory/plugins/normalMode.ts
Outdated
Show resolved
Hide resolved
packages/create-sitecore-jss/src/templates/nextjs-personalize/.env
Outdated
Show resolved
Hide resolved
packages/create-sitecore-jss/src/templates/nextjs-personalize/package.json
Outdated
Show resolved
Hide resolved
...rc/templates/nextjs-personalize/src/components/graphql/GraphQL-ConnectedDemo.dynamic.graphql
Outdated
Show resolved
Hide resolved
...ecore-jss/src/templates/nextjs-personalize/src/lib/page-props-factory/plugins/personalize.ts
Outdated
Show resolved
Hide resolved
...es/create-sitecore-jss/src/templates/nextjs/src/lib/page-props-factory/plugins/normalMode.ts
Outdated
Show resolved
Hide resolved
packages/create-sitecore-jss/src/templates/nextjs-personalize/src/lib/component-props/index.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! 👍
Transferred the Personalize nextjs POC work.
Description / Motivation
Testing Details
Types of changes