Initializer for node-headless-ssr-proxy sample
#876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/sitecore-jss/edge-e2e-styleguide/6zPq8Z8rWvU7ibE8RZMDTwozkjZ4 [Deployment for 9043065 failed] |
packages/create-sitecore-jss/src/templates/node-headless-ssr-proxy/httpAgents.js
Show resolved
Hide resolved
packages/create-sitecore-jss/src/templates/node-headless-ssr-proxy/package.json
Outdated
Show resolved
Hide resolved
illiakovalenko
requested changes
Dec 9, 2021
CobyPear
reviewed
Dec 9, 2021
packages/create-sitecore-jss/src/templates/node-headless-ssr-proxy/config.js
Show resolved
Hide resolved
ambrauer
force-pushed
the
diy-generator-ssr-proxy
branch
from
9560d4c to
9043065
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description / Motivation
!!PLEASE DO NOT MERGE!!
Note, decided not to make enhancements to drive
config.jswith prompted values (e.g.appName). Those enhancements could be made later on (for example when introducing a .env). For now, we have 100% parity with existing sample / jss create.Testing Details
Types of changes