Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Focused Improvements] [React] [NextJS] Attributes of an empty placeholder are applied to the next sibling <div> tag in Experience Editor of JSS item #833

Merged
merged 3 commits into from
Oct 19, 2021

Conversation

illiakovalenko
Copy link
Contributor

@illiakovalenko illiakovalenko commented Oct 18, 2021

[Focused Improvements] [React] [NextJS] Attributes of an empty placeholder are applied to the next sibling

tag in Experience Editor of JSS item

Description / Motivation

In case if we need to render empty placeholder, some part of markup will be inserted by EE,
so we need to separate empty placeholder's markup and allow react reconciliation to be executed correctly and don't mess sibling tags.

Inserted by EE:

image

Testing Details

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update (non-breaking change; modified files are limited to the /docs directory)

… to the next sibling <div> tag in Experience Editor of NextJS JSS item
@vercel
Copy link

vercel bot commented Oct 18, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/sitecore-jss/edge-e2e-styleguide/6Shy5QiaNmCsVmtC9B5FJfJDRhkZ
✅ Preview: https://edge-e2e-styleguide-git-bugfix-487854-sitecore-jss.vercel.app

@illiakovalenko illiakovalenko requested a review from a team October 18, 2021 13:16
Copy link
Contributor

@CobyPear CobyPear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment, looks good otherwise.

packages/sitecore-jss-react/src/components/Placeholder.tsx Outdated Show resolved Hide resolved
@illiakovalenko illiakovalenko merged commit 90abf38 into dev Oct 19, 2021
@illiakovalenko illiakovalenko deleted the bugfix/487854 branch October 19, 2021 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants