-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Nextjs] Use the app name as the prefix value for templates #800
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/sitecore-jss/edge-e2e-styleguide/Gc7iaWwqJwuez84sNFdA4tx2d7ym [Deployment for cf39f5b failed] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is working brilliantly. Not sure if you had this planned for "phase 2" (apply to RAV), but we discussed adding a flag to jss create
to make the prefix opt-in (for backwards compatibility). I think this is still valuable, and I don't think it'd be that much extra work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple minor things, otherwise looks good!
…/jss into feature/482700-prefix-templates
When developing locally, multiple templates with the same name will conflict causing errors when using strongly typed GraphQL queries.
This feature adds a prefix to some files so that when
jss create
is run, the prefix is replaced with the appname, which will give each template a unique name in Sitecore when usingjss deploy
Description / Motivation
sitecore-jss-cli
that replaces the prefix with the appnameFaster internal development
Testing Details
Types of changes
/docs
directory)