Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Angular] remove the server wrapper from angular sample app #522

Closed
wants to merge 3 commits into from
Closed

[Angular] remove the server wrapper from angular sample app #522

wants to merge 3 commits into from

Conversation

evtk
Copy link

@evtk evtk commented Dec 29, 2020

Description

I have looked into the Angular Universal solution and they do not seem to inclulde 2 tasks for building the server bundle. After some researching I have found a few simple changes in the setup of the sample Angular, which seem to produce a valid server bundle, but not only with just one build task (build:server), also half the bundle size!

Motivation

By omitting the server wrapper, we can remove the need for its additional configuration and the build:task. This definitly speeds up the development process. As a bonus: the output of the bundle is half its original size.

How Has This Been Tested?

I have tested this in our own corporate setup. We have implemented it there and was asked to provide a pull request.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update (non-breaking change; modified files are limited to the /docs directory)

Checklist:

  • I have read the Contributing guide.
  • My code follows the code style of this project.
  • My code/comments/docs fully adhere to the Code of Conduct.
  • My change is a code change and it requires an update to the documentation.
  • My change is a documentation change and it requires an update to the navigation.

@evtk evtk changed the title Remove the server wrapper from angular sample app [Angular] remove the server wrapper from angular sample app Dec 29, 2020
@illiakovalenko illiakovalenko changed the base branch from master to dev March 4, 2021 11:34
@illiakovalenko
Copy link
Contributor

@evtk Thank you, I merged your changes in #617

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants