Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated react sample scripts #374

Merged
merged 1 commit into from
May 20, 2020
Merged

Conversation

ndsnas
Copy link
Contributor

@ndsnas ndsnas commented May 18, 2020

Fixed package.json script -> start:connected-ssr

Description

"start:connected-ssr": "scjss-verify-setup && npm-run-all --serial bootstrap:connected --parallel start:react start:watch-components start:http-renderer"
start:http-renderer: doesn't exist in scripts
it should be start:http-renderer-holygrail

Motivation

jss start:connected-ssr gives error as it can't find start:http-renderer in scripts.

How Has This Been Tested?

tested by running jss start:connected-ssr. It ran successfully start:react and holygrail in parallel.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update (non-breaking change; modified files are limited to the /docs directory)

Checklist:

  • I have read the Contributing guide.
  • My code follows the code style of this project.
  • My code/comments/docs fully adhere to the Code of Conduct.
  • My change is a code change and it requires an update to the documentation.
  • My change is a documentation change and it requires an update to the navigation.

Fixed package.json script -> start:connected-ssr
@ndsnas ndsnas changed the title Updated scripts Updated react sample scripts May 18, 2020
@sc-illiakovalenko sc-illiakovalenko merged commit 54f34bc into Sitecore:dev May 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants