[sitecore-jss-dev-tools] Update sitecore packages metadata generation logic to account for monorepos #1949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ackage-lock instead of node-modules
yavorsk
changed the title
art-alexeyenko
requested changes
Oct 15, 2024
…endencies the have smaller files
illiakovalenko
approved these changes
Oct 22, 2024
packages/sitecore-jss-dev-tools/src/templating/metadata.test.ts
Outdated
Show resolved
Hide resolved
art-alexeyenko
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description / Motivation
Previously getMetadata() was generating the metadata about the used sitecore packages through traversing the node-modules folder of the application. This approach does not work in a monorepo setup.
This PR addresses the problem by making some updates of the logic that gathers the metadata - it uses the
npm querycommand to gather the information of the used sitecore packages and their exact version.Testing Details
Types of changes