Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[templates/nextjs-sxa] Fix SXA Image sizing in Metadata mode #1861

Closed
wants to merge 2 commits into from
Closed

[templates/nextjs-sxa] Fix SXA Image sizing in Metadata mode #1861

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
024f744
[templates/nextjs-sxa] Fix SXA Image sizing in Metadata mode
art-alexeyenko Jul 29, 2024
2ef03dc
changelog
art-alexeyenko Jul 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ Our versioning strategy is as follows:

* `[templates/nextjs]` `[templates/react]` `[templates/vue]` `[templates/angular]` Changed formatting in temp/config to prevent parse issues in Unix systems ([#1787](https://github.com/Sitecore/jss/pull/1787))([#1791](https://github.com/Sitecore/jss/pull/1791))
* `[sitecore-jss]` `GraphQLRequestClientFactory` type is updated and `config` parameter is now optional. Since it should match `GraphQLRequestClient.createClientFactory` method return type ([#1806](https://github.com/Sitecore/jss/pull/1806))
* `[templates/nextjs-sxa]` The banner variant of image component is fixed with supporting metadata mode. ([#1826](https://github.com/Sitecore/jss/pull/1826))
* `[templates/nextjs-sxa]` The banner variant of image component is fixed with supporting metadata mode. ([#1826](https://github.com/Sitecore/jss/pull/1826))([#1861](https://github.com/Sitecore/jss/pull/1861))
* `[sitecore-jss]` `[sitecore-jss-react]` DateField empty value is not treated as empty ([#1836](https://github.com/Sitecore/jss/pull/1836))
* `[templates/nextjs-sxa]` Fix styles of title component in metadata mode. ([#1839](https://github.com/Sitecore/jss/pull/1839))
* `[templates/nextjs-sxa]` Fix missing value of field property in Title component. ([#1842](https://github.com/Sitecore/jss/pull/1842))
Expand Down
31 changes: 18 additions & 13 deletions packages/create-sitecore-jss/src/templates/nextjs-sxa/src/components/Image.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,22 +41,27 @@ export const Banner = (props: ImageProps): JSX.Element => {
const backgroundStyle = (props?.fields?.Image?.value?.src && {
backgroundImage: `url('${props.fields.Image.value.src}')`,
}) as CSSProperties;
const modifyImageProps = !isMetadataMode
? {
...props.fields.Image,
editable: props?.fields?.Image?.editable
?.replace(`width="${props?.fields?.Image?.value?.width}"`, 'width="100%"')
.replace(`height="${props?.fields?.Image?.value?.height}"`, 'height="100%"'),
}
: {
...props.fields.Image,
let modifyImageProps = props.fields.Image;
if (isMetadataMode) {
if (modifyImageProps.value) {
delete modifyImageProps.value.width;
delete modifyImageProps.value.height;
}
modifyImageProps = {
...modifyImageProps,
value: {
...props.fields.Image.value,
width: "100%",
height: "100%",
...modifyImageProps.value,
sizes: '100vw',
},
};

} else {
modifyImageProps = {
...modifyImageProps,
editable: props?.fields?.Image?.editable
?.replace(`width="${props?.fields?.Image?.value?.width}"`, 'width="100%"')
.replace(`height="${props?.fields?.Image?.value?.height}"`, 'height="100%"'),
};
}
return (
<div
className={`component hero-banner ${props.params.styles} ${classHeroBannerEmpty}`}
Expand Down