Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sitecore-jss-react] Address later comments from PR 1807 #1809

Merged
merged 3 commits into from
Jun 5, 2024

Conversation

art-alexeyenko
Copy link
Contributor

@art-alexeyenko art-alexeyenko commented Jun 4, 2024

A quick follow up for #1807 to address post-merge comments.

  • Add missing comments
  • Adjust the types in sharedTypes
  • streamline the logic for not wrapping empty components in placeholder

@art-alexeyenko art-alexeyenko requested a review from a team June 4, 2024 17:13
Copy link
Contributor

@illiakovalenko illiakovalenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@art-alexeyenko art-alexeyenko changed the title Address later comments from PR 1807 [sitecore-jss-react] Address later comments from PR 1807 Jun 5, 2024
@art-alexeyenko art-alexeyenko merged commit a6aceac into dev Jun 5, 2024
1 check passed
@art-alexeyenko art-alexeyenko deleted the bug/jss-3363-hydration-followup branch June 5, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants