Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Chore] Clean up deprecations #1780

Merged
merged 6 commits into from
Apr 23, 2024
Merged

[Chore] Clean up deprecations #1780

merged 6 commits into from
Apr 23, 2024

Conversation

art-alexeyenko
Copy link
Contributor

@art-alexeyenko art-alexeyenko commented Apr 19, 2024 •
edited
Loading

Description / Motivation

Part of JSS 22 release preparations. Cleans up deprecated parameters, exports etc across the board.

Changelog + Upgrade guide entries TBA

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@art-alexeyenko art-alexeyenko requested a review from a team April 19, 2024 22:33
@art-alexeyenko
Merge branch 'dev' of https://github.com/Sitecore/jss into chore/v22-…
91e8195 
…remove-deprecations

# Conflicts:
#	CHANGELOG.md
#	docs/upgrades/unreleased.md
illiakovalenko
illiakovalenko requested changes Apr 22, 2024
View reviewed changes
Copy link
Contributor

@illiakovalenko illiakovalenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Take a look also at these files:
https://github.com/Sitecore/jss/blob/dev/packages/create-sitecore-jss/src/templates/nextjs-sxa/src/pages/api/robots.ts#L16
https://github.com/Sitecore/jss/blob/dev/packages/create-sitecore-jss/src/templates/nextjs-sxa/src/pages/api/sitemap.ts
I think it's required to update them before the release, otherwise it will not be possible to build

CHANGELOG.md Show resolved Hide resolved
packages/sitecore-jss-react/src/components/Image.tsx Outdated Show resolved Hide resolved
packages/sitecore-jss/src/layout/graphql-layout-service.ts Show resolved Hide resolved
packages/sitecore-jss/src/site/graphql-siteinfo-service.ts Show resolved Hide resolved
packages/sitecore-jss/src/feaas/index.ts Outdated Show resolved Hide resolved
@illiakovalenko
Copy link
Contributor

Are our README files updated by automation scripts?
https://github.com/Sitecore/jss/blob/chore/v22-remove-deprecations/packages/create-sitecore-jss/README.md?plain=1#L8
There should be a reference to 22 version

@illiakovalenko
Copy link
Contributor

illiakovalenko commented Apr 23, 2024 •
edited
Loading

@art-alexeyenko you didn't update other README files. I didn't provide a full list of links, since I expected that you will check them :)
e.g.
https://github.com/Sitecore/jss/blob/chore/v22-remove-deprecations/packages/sitecore-jss-cli/README.md?plain=1#L8
https://github.com/Sitecore/jss/blob/chore/v22-remove-deprecations/packages/sitecore-jss-nextjs/README.md?plain=1#L8

(I still suppose that they should be updated by release script, but I've already pushed the changes)

Are our README files updated by automation scripts? https://github.com/Sitecore/jss/blob/chore/v22-remove-deprecations/packages/create-sitecore-jss/README.md?plain=1#L8 There should be a reference to 22 version

illiakovalenko
illiakovalenko approved these changes Apr 23, 2024
View reviewed changes
Copy link
Contributor

@illiakovalenko illiakovalenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@illiakovalenko illiakovalenko merged commit 139f50a into dev Apr 23, 2024
1 check was pending
@illiakovalenko illiakovalenko deleted the chore/v22-remove-deprecations branch April 23, 2024 08:26
@art-alexeyenko
Copy link
Contributor Author

(I still suppose that they should be updated by release script, but I've already pushed the changes)

I'm not sure they will be updated by our scripts. Let me update them, thanks for the heads up

@illiakovalenko
Copy link
Contributor

@art-alexeyenko I've updated them, they reference v22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@illiakovalenko illiakovalenko illiakovalenko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@art-alexeyenko @illiakovalenko