Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Next.js] Deployment Protection Bypass support for Editing #1634

Merged
merged 2 commits into from
Oct 19, 2023

Conversation

ambrauer
Copy link
Contributor

Description / Motivation

Added support for deployment protection bypass query string parameters (or any query string parameters, really) on the editing/render endpoint. Currently, this is setup for Sitecore (x-sitecore-protection-bypass) and Vercel (x-vercel-protection-bypass) protection bypass query parameters, but could easily be extended to handle others.

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

…s (or any query string parameters, really) on the editing/render endpoint. Currently, this is setup for Sitecore and Vercel protection bypass query params, but could easily be extended to handle others.
@ambrauer ambrauer marked this pull request as ready for review October 18, 2023 20:45
@ambrauer ambrauer requested a review from a team October 18, 2023 20:45
Copy link
Contributor

@addy-pathania addy-pathania left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 👍🏼

@ambrauer ambrauer merged commit 35a590d into dev Oct 19, 2023
@ambrauer ambrauer deleted the feature/JSS-851-protection-bypass-support branch October 19, 2023 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants