[sitecore-jss-nextjs] Referrer is not captured by Personalize middleware #1542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
83
to
85
| referer: referrer, | ||
| }, | ||
| referrer, | ||
| referrer: 'about:client', |
There was a problem hiding this comment.
Should there be a test case to check both scenarios?
There was a problem hiding this comment.
@sc-addypathania Good point! I changed the existing test case and now it's verifying when the referer is empty, the opposite case when the referer exists is covered in the rest of the unit tests. Looks good?
addy-pathania
approved these changes
Jun 28, 2023
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description / Motivation
Personalize middleware doesn't access a real referrer value (from headers), instead, it provided a default "about:client" value from the request
Testing Details
Types of changes