Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[create-sitecore-jss] Fix prePushHook prompt #1468

Merged
merged 3 commits into from
May 4, 2023
Merged

[create-sitecore-jss] Fix prePushHook prompt #1468

merged 3 commits into from
May 4, 2023

Conversation

addy-pathania
Copy link
Contributor

@addy-pathania addy-pathania commented May 4, 2023 •
edited
Loading

When prePushHook is set to false through the command line args it should not prompt the user again for prePushHook.

Description / Motivation

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@addy-pathania addy-pathania requested a review from a team May 4, 2023 01:52
ambrauer
ambrauer approved these changes May 4, 2023
View reviewed changes
Copy link
Contributor

@ambrauer ambrauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@ambrauer ambrauer merged commit 6f40431 into dev May 4, 2023
@ambrauer ambrauer deleted the bug/583778-pre-push-hook-prompt branch May 4, 2023 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ambrauer ambrauer ambrauer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@addy-pathania @ambrauer